freedak/Scrapling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(Fetchers/page_action): Fixing logic

Browse Source
This commit is contained in:
Karim shoair
2024-12-16 12:34:23 +02:00
parent 3ecffcb81c
commit eceef48ef5
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scrapling/engines/camo.py
+6 -3
View File
@@ -64,11 +64,14 @@ class CamoufoxEngine:
self.addons = addons or [] self.addons = addons or []
self.humanize = humanize self.humanize = humanize
self.timeout = check_type_validity(timeout, [int, float], 30000) self.timeout = check_type_validity(timeout, [int, float], 30000)
if callable(page_action): if page_action is not None:
self.page_action = page_action if callable(page_action):
self.page_action = page_action
else:
self.page_action = None
log.error('[Ignored] Argument "page_action" must be callable')
else: else:
self.page_action = None self.page_action = None
log.error('[Ignored] Argument "page_action" must be callable')
self.wait_selector = wait_selector self.wait_selector = wait_selector
self.wait_selector_state = wait_selector_state self.wait_selector_state = wait_selector_state
scrapling/engines/pw.py
+6 -3
View File
@@ -75,11 +75,14 @@ class PlaywrightEngine:
self.cdp_url = cdp_url self.cdp_url = cdp_url
self.useragent = useragent self.useragent = useragent
self.timeout = check_type_validity(timeout, [int, float], 30000) self.timeout = check_type_validity(timeout, [int, float], 30000)
if page_action is not None and callable(page_action): if page_action is not None:
self.page_action = page_action if callable(page_action):
self.page_action = page_action
else:
self.page_action = None
log.error('[Ignored] Argument "page_action" must be callable')
else: else:
self.page_action = None self.page_action = None
log.error('[Ignored] Argument "page_action" must be callable')
self.wait_selector = wait_selector self.wait_selector = wait_selector
self.wait_selector_state = wait_selector_state self.wait_selector_state = wait_selector_state