From e60a57c63fe80ce25c94243c735d201631cf92b4 Mon Sep 17 00:00:00 2001
From: Karim shoair <D4Vinci@users.noreply.github.com>
Date: Tue, 10 Dec 2024 22:37:37 +0200
Subject: [PATCH] Python 3.8 is not supported anymore

It's not supported in the new version of Playwright and is problematic in some situations while being slower than newer versions.
---
 .pre-commit-config.yaml | 2 +-
 setup.py                | 2 +-
 tox.ini                 | 5 ++---
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 9e3cf04..4b90529 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -16,4 +16,4 @@ repos:
   rev: v1.6.0
   hooks:
   - id: vermin
-    args: ['-t=3.8-', '--violations', '--eval-annotations', '--no-tips']
+    args: ['-t=3.9-', '--violations', '--eval-annotations', '--no-tips']
diff --git a/setup.py b/setup.py
index bfbb741..7d706c1 100644
--- a/setup.py
+++ b/setup.py
@@ -60,7 +60,7 @@ setup(
         'camoufox>=0.4.7',
         'browserforge',
     ],
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     url="https://github.com/D4Vinci/Scrapling",
     project_urls={
         "Documentation": "https://github.com/D4Vinci/Scrapling/tree/main/docs",  # For now
diff --git a/tox.ini b/tox.ini
index 28b09e1..b539b49 100644
--- a/tox.ini
+++ b/tox.ini
@@ -4,7 +4,7 @@
 # and then run "tox" from this directory.
 
 [tox]
-envlist = pre-commit,py{38,39,310,311,312,313}
+envlist = pre-commit,py{39,310,311,312,313}
 
 [testenv]
 usedevelop = True
@@ -15,8 +15,7 @@ commands =
     playwright install chromium
     playwright install-deps chromium firefox
     camoufox fetch --browserforge
-    py38: pytest --config-file=pytest.ini --cov=scrapling --cov-report=xml
-    py{39,310,311,312,313}: pytest --config-file=pytest.ini --cov=scrapling --cov-report=xml -n auto
+    pytest --config-file=pytest.ini --cov=scrapling --cov-report=xml -n auto
 
 [testenv:pre-commit]
 basepython = python3