test: add edge case tests for filter, iterancestors, and find_similar

- test_selectors_filter.py: covers chained filter(), empty result, all-pass predicate, and calling filter() on empty Selectors - test_ancestor_navigation.py: covers iterancestors() order, depth, text-node safety, root-element edge case, and find_ancestor() with no match - test_find_similar_advanced.py: covers similarity_threshold levels, match_text=True behavior, ignore_attributes combinations, and text-node safety
2026-03-16 18:01:11 +08:00
parent 72a2c8de81
commit cec5acd68a
3 changed files with 208 additions and 0 deletions
@@ -0,0 +1,66 @@
+"""
+Tests for Selector.iterancestors() and Selector.find_ancestor() methods.
+Target file: tests/parser/test_general.py (append to TestElementNavigation class)
+"""
+import pytest
+from scrapling import Selector
+
+
+@pytest.fixture
+def nested_page():
+    html = """
+    <html><body>
+        <div id="level1">
+            <section id="level2" class="wrapper">
+                <article id="level3" class="card">
+                    <p id="level4"><span id="target">deep text</span></p>
+                </article>
+            </section>
+        </div>
+    </body></html>
+    """
+    return Selector(html, adaptive=False)
+
+
+class TestAncestorNavigation:
+    def test_iterancestors_returns_all_ancestors(self, nested_page):
+        """iterancestors() should yield every ancestor up to <html>"""
+        target = nested_page.css("#target")[0]
+        ancestor_tags = [a.tag for a in target.iterancestors()]
+        # Expected order: p → article → section → div → body → html
+        assert ancestor_tags[:4] == ["p", "article", "section", "div"]
+        assert "body" in ancestor_tags
+        assert "html" in ancestor_tags
+
+    def test_iterancestors_order_is_bottom_up(self, nested_page):
+        """iterancestors() should start from the immediate parent, not the root"""
+        target = nested_page.css("#target")[0]
+        first_ancestor = next(target.iterancestors())
+        assert first_ancestor.attrib.get("id") == "level4"
+
+    def test_find_ancestor_returns_first_match(self, nested_page):
+        """find_ancestor() should return the closest ancestor matching the predicate"""
+        target = nested_page.css("#target")[0]
+        # Looking for the nearest ancestor with class "card"
+        result = target.find_ancestor(lambda el: el.has_class("card"))
+        assert result is not None
+        assert result.attrib.get("id") == "level3"
+
+    def test_find_ancestor_returns_none_when_not_found(self, nested_page):
+        """find_ancestor() should return None if no ancestor matches"""
+        target = nested_page.css("#target")[0]
+        result = target.find_ancestor(lambda el: el.has_class("nonexistent-class"))
+        assert result is None
+
+    def test_iterancestors_on_text_node_is_empty(self, nested_page):
+        """iterancestors() on a text node should yield nothing (not raise)"""
+        text_node = nested_page.css("#target::text")[0]
+        ancestors = list(text_node.iterancestors())
+        assert ancestors == []
+
+    def test_find_ancestor_on_root_element_returns_none(self, nested_page):
+        """find_ancestor() on the root <html> element should return None gracefully"""
+        # html element has no ancestors
+        html_el = nested_page.css("html")[0]
+        result = html_el.find_ancestor(lambda el: True)
+        assert result is None