From a5e4b91653a557e6d846474c558c51cd32773881 Mon Sep 17 00:00:00 2001 From: Karim shoair Date: Mon, 28 Jul 2025 14:48:22 +0300 Subject: [PATCH] refactor: remove clean up function for Adaptor + make adaptor attributes accessible directly --- scrapling/parser.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/scrapling/parser.py b/scrapling/parser.py index 3ff3f2c..0371c99 100644 --- a/scrapling/parser.py +++ b/scrapling/parser.py @@ -185,15 +185,11 @@ class Adaptor(SelectorsGeneration): else {} ) - def __del__(self): - """Ensure cleanup happens""" - if hasattr(self, "_storage") and self._storage: - try: - self._storage.close() - except Exception: - pass - finally: - self._storage = None + def __getitem__(self, key: str) -> TextHandler: + return self.attrib[key] + + def __contains__(self, key: str) -> bool: + return key in self.attrib # Node functionalities, I wanted to move to a separate Mixin class, but it had a slight impact on performance @staticmethod