tests: changing tests accordingly

This commit is contained in:
Karim shoair
2025-09-08 16:09:24 +03:00
parent ecaec65049
commit 931993f901
2 changed files with 11 additions and 42 deletions
+1 -2
View File
@@ -53,7 +53,6 @@ class TestStealthySession:
"""Test if the session is created correctly""" """Test if the session is created correctly"""
with StealthySession( with StealthySession(
max_pages=3,
headless=True, headless=True,
block_images=True, block_images=True,
disable_resources=True, disable_resources=True,
@@ -63,7 +62,7 @@ class TestStealthySession:
cookies=[{"name": "test", "value": "123", "domain": "example.com", "path": "/"}], cookies=[{"name": "test", "value": "123", "domain": "example.com", "path": "/"}],
) as session: ) as session:
assert session.max_pages == 3 assert session.max_pages == 1
assert session.headless is True assert session.headless is True
assert session.block_images is True assert session.block_images is True
assert session.disable_resources is True assert session.disable_resources is True
+10 -40
View File
@@ -24,8 +24,8 @@ class TestPageInfo:
assert page_info.state == "busy" assert page_info.state == "busy"
assert page_info.url == "https://example.com" assert page_info.url == "https://example.com"
page_info.mark_ready() page_info.mark_finished()
assert page_info.state == "ready" assert page_info.state == "finished"
assert page_info.url == "" assert page_info.url == ""
page_info.mark_error() page_info.mark_error()
@@ -63,7 +63,6 @@ class TestPagePool:
assert pool.max_pages == 5 assert pool.max_pages == 5
assert pool.pages_count == 0 assert pool.pages_count == 0
assert pool.ready_count == 0
assert pool.busy_count == 0 assert pool.busy_count == 0
def test_add_page(self): def test_add_page(self):
@@ -97,42 +96,13 @@ class TestPagePool:
page1 = pool.add_page(Mock()) page1 = pool.add_page(Mock())
page2 = pool.add_page(Mock()) page2 = pool.add_page(Mock())
# Mark one as busy # Mark them as finished
page1.mark_busy("https://example.com") page1.mark_finished()
page2.mark_finished()
# Should get the ready page # test
ready_page = pool.get_ready_page() pool.close_all_finished_pages()
assert ready_page == page2 assert pool.pages_count == 0
def test_get_ready_page_none_available(self):
"""Test getting ready page when none available"""
pool = PagePool(max_pages=2)
# Add pages and mark all as busy
page1 = pool.add_page(Mock())
page2 = pool.add_page(Mock())
page1.mark_busy("https://example1.com")
page2.mark_busy("https://example2.com")
# Should return None
ready_page = pool.get_ready_page()
assert ready_page is None
def test_page_counts(self):
"""Test page count properties"""
pool = PagePool(max_pages=3)
# Add pages with different states
page1 = pool.add_page(Mock())
page2 = pool.add_page(Mock())
page3 = pool.add_page(Mock())
page1.mark_busy("https://example.com")
page3.mark_error()
assert pool.pages_count == 3
assert pool.ready_count == 1
assert pool.busy_count == 1
def test_cleanup_error_pages(self): def test_cleanup_error_pages(self):
"""Test cleaning up error pages""" """Test cleaning up error pages"""
@@ -140,7 +110,7 @@ class TestPagePool:
# Add pages # Add pages
page1 = pool.add_page(Mock()) page1 = pool.add_page(Mock())
page2 = pool.add_page(Mock()) _ = pool.add_page(Mock())
page3 = pool.add_page(Mock()) page3 = pool.add_page(Mock())
# Mark some as error # Mark some as error
@@ -151,4 +121,4 @@ class TestPagePool:
pool.cleanup_error_pages() pool.cleanup_error_pages()
assert pool.pages_count == 1 # Only page2 should remain assert pool.pages_count == 1 # Only 2 should remain