From 7a7097b7757574a4af2013d434576eb02ef654ec Mon Sep 17 00:00:00 2001 From: Karim shoair Date: Mon, 15 Sep 2025 13:43:47 +0300 Subject: [PATCH] fix: Stop removing browser default page Looks like it's problematic with some systems so it doesn't worth the trouble --- scrapling/engines/_browsers/_camoufox.py | 8 -------- scrapling/engines/_browsers/_controllers.py | 8 -------- 2 files changed, 16 deletions(-) diff --git a/scrapling/engines/_browsers/_camoufox.py b/scrapling/engines/_browsers/_camoufox.py index 6e0bc1e..ad515ca 100644 --- a/scrapling/engines/_browsers/_camoufox.py +++ b/scrapling/engines/_browsers/_camoufox.py @@ -173,10 +173,6 @@ class StealthySession(StealthySessionMixin, SyncSession): **self.launch_options ) - # Get the default page and close it - default_page = self.context.pages[0] - default_page.close() - if self.init_script: # pragma: no cover self.context.add_init_script(path=self.init_script) @@ -482,10 +478,6 @@ class AsyncStealthySession(StealthySessionMixin, AsyncSession): **self.launch_options ) - # Get the default page and close it - default_page = self.context.pages[0] - await default_page.close() - if self.init_script: # pragma: no cover await self.context.add_init_script(path=self.init_script) diff --git a/scrapling/engines/_browsers/_controllers.py b/scrapling/engines/_browsers/_controllers.py index 07efee2..70b3771 100644 --- a/scrapling/engines/_browsers/_controllers.py +++ b/scrapling/engines/_browsers/_controllers.py @@ -168,10 +168,6 @@ class DynamicSession(DynamicSessionMixin, SyncSession): else: self.context = self.playwright.chromium.launch_persistent_context(user_data_dir="", **self.launch_options) - # Get the default page and close it - default_page = self.context.pages[0] - default_page.close() - if self.init_script: # pragma: no cover self.context.add_init_script(path=self.init_script) @@ -421,10 +417,6 @@ class AsyncDynamicSession(DynamicSessionMixin, AsyncSession): user_data_dir="", **self.launch_options ) - # Get the default page and close it - default_page = self.context.pages[0] - await default_page.close() - if self.init_script: # pragma: no cover await self.context.add_init_script(path=self.init_script)