From 273c8c2fa02db3003db604c8b21447574440d3c0 Mon Sep 17 00:00:00 2001 From: sjhddh Date: Sun, 12 Apr 2026 09:46:55 +0200 Subject: [PATCH] fix: emit valid XPath node test for ID elements in full-path mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address review feedback: In full-path XPath generation, elements with IDs were producing bare predicates like `[@id='x']` which creates invalid XPath steps like `//body/[@id='main']`. Now emits `*[@id='x']` for full-path mode (e.g. `//body/*[@id='main']/*[@id='target']`). Short-path XPath mode unchanged — still uses `//*[@id='x']` prefix. Also added XPath evaluation assertion to the regression test to verify the generated selector actually selects the correct element. Co-Authored-By: Claude Opus 4.6 --- scrapling/core/mixins.py | 7 ++++++- tests/parser/test_general.py | 5 +++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/scrapling/core/mixins.py b/scrapling/core/mixins.py index 5cbcba4..868d620 100644 --- a/scrapling/core/mixins.py +++ b/scrapling/core/mixins.py @@ -26,7 +26,12 @@ class SelectorsGeneration: if target.parent: if target.attrib.get("id"): # id is enough - part = f"#{target.attrib['id']}" if css else f"[@id='{target.attrib['id']}']" + if css: + part = f"#{target.attrib['id']}" + elif full_path: + part = f"*[@id='{target.attrib['id']}']" + else: + part = f"[@id='{target.attrib['id']}']" selectorPath.append(part) if not full_path: return " > ".join(reversed(selectorPath)) if css else "//*" + "/".join(reversed(selectorPath)) diff --git a/tests/parser/test_general.py b/tests/parser/test_general.py index 3961660..293e93e 100644 --- a/tests/parser/test_general.py +++ b/tests/parser/test_general.py @@ -342,6 +342,11 @@ def test_full_path_selector_no_duplicate_ids(): assert len(result) == 1 assert result.first.text == "Hello" + # The generated XPath selector should also select the correct element + result = page.xpath(xpath_full) + assert len(result) == 1, f"XPath '{xpath_full}' selected {len(result)} elements, expected 1" + assert result.first.text == "Hello" + def test_full_path_selector_mixed_id_and_no_id(): """Test full path selectors with a mix of elements with and without ids"""