From 183950662262dd50711396af48ab2f5d9afdbb65 Mon Sep 17 00:00:00 2001 From: Karim shoair Date: Tue, 3 Mar 2026 23:08:15 +0200 Subject: [PATCH] fix(browsers): make flag concatenation type-safe Better implementation of #157 that's accepted by pyright/mypy. Thanks to @rostchri . Co-Authored-By: Christian Rost --- scrapling/engines/_browsers/_base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scrapling/engines/_browsers/_base.py b/scrapling/engines/_browsers/_base.py index 51ce308..501db76 100644 --- a/scrapling/engines/_browsers/_base.py +++ b/scrapling/engines/_browsers/_base.py @@ -419,7 +419,7 @@ class BaseSessionMixin: if not config.cdp_url: flags = self._browser_options["args"] if config.extra_flags or extra_flags: - flags = list(set(flags + (config.extra_flags or extra_flags))) + flags = list(set(tuple(flags) + tuple(config.extra_flags or extra_flags or ()))) self._browser_options.update( { @@ -480,7 +480,7 @@ class StealthySessionMixin(BaseSessionMixin): config = cast(StealthConfig, self._config) flags: Tuple[str, ...] = tuple() if not config.cdp_url: - flags = DEFAULT_ARGS + STEALTH_ARGS + flags = tuple(DEFAULT_ARGS) + tuple(STEALTH_ARGS) if config.block_webrtc: flags += (