freedak/Scrapling
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(dynamic Fetcher): small optimization

Browse Source
This commit is contained in:
Karim shoair
2025-08-16 23:20:54 +03:00
parent 3e0ca33111
commit 009bbb20c0
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scrapling/engines/_browsers/_controllers.py
+8 -9
View File
@@ -4,7 +4,6 @@ from asyncio import sleep as asyncio_sleep, Lock
from playwright.sync_api import ( from playwright.sync_api import (
Response as SyncPlaywrightResponse, Response as SyncPlaywrightResponse,
sync_playwright, sync_playwright,
BrowserType,
BrowserContext, BrowserContext,
Playwright, Playwright,
Locator, Locator,
@@ -12,7 +11,6 @@ from playwright.sync_api import (
from playwright.async_api import ( from playwright.async_api import (
async_playwright, async_playwright,
Response as AsyncPlaywrightResponse, Response as AsyncPlaywrightResponse,
BrowserType as AsyncBrowserType,
BrowserContext as AsyncBrowserContext, BrowserContext as AsyncBrowserContext,
Playwright as AsyncPlaywright, Playwright as AsyncPlaywright,
Locator as AsyncLocator, Locator as AsyncLocator,
@@ -236,12 +234,12 @@ class DynamicSession:
self.playwright = sync_context().start() self.playwright = sync_context().start()
browser_launcher: BrowserType = self.playwright.chromium
if self.cdp_url: if self.cdp_url:
browser = browser_launcher.connect_over_cdp(endpoint_url=self.cdp_url) self.context = self.playwright.chromium.connect_over_cdp(
self.context = browser.new_context(**self.context_options) endpoint_url=self.cdp_url
).new_context(**self.context_options)
else: else:
self.context = browser_launcher.launch_persistent_context( self.context = self.playwright.chromium.launch_persistent_context(
user_data_dir="", **self.launch_options user_data_dir="", **self.launch_options
) )
@@ -482,15 +480,16 @@ class AsyncDynamicSession(DynamicSession):
self.playwright: AsyncPlaywright = await async_context().start() self.playwright: AsyncPlaywright = await async_context().start()
browser_launcher: AsyncBrowserType = self.playwright.chromium
if self.cdp_url: if self.cdp_url:
browser = await browser_launcher.connect_over_cdp(endpoint_url=self.cdp_url) browser = await self.playwright.chromium.connect_over_cdp(
endpoint_url=self.cdp_url
)
self.context: AsyncBrowserContext = await browser.new_context( self.context: AsyncBrowserContext = await browser.new_context(
**self.context_options **self.context_options
) )
else: else:
self.context: AsyncBrowserContext = ( self.context: AsyncBrowserContext = (
await browser_launcher.launch_persistent_context( await self.playwright.chromium.launch_persistent_context(
user_data_dir="", **self.launch_options user_data_dir="", **self.launch_options
) )
) )