freedak/OpenMontage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(atelier): post-render review hook + reviewer enforcement (F6 + F7)

Browse Source 
Closes the two biggest gaps from the atelier audit: hero bespoke renders
were skipping every automated quality gate, and the templated→atelier
inversion was advisory rather than enforced.

F6 — _render_via_atelier now runs the full _run_final_review (technical
probe + visual spotcheck + audio spotcheck + duration drift + transcript
comparison) plus two atelier-specific doctrine checks:

  - stock_reuse_check: rglobs the bespoke project tree for imports from
    the stock creative registry (src/components, src/Explainer, etc.).
    Any hit fails the render with status="fail" and names the offending
    file — the doctrine bypass is now mechanically caught.
  - art_direction_check: requires edit_decisions.bespoke.art_direction.
    Missing → warning surfaced in final_review.issues_found; forcing
    function for step 1 of skills/meta/bespoke-composition.md.

Verified end-to-end on the compound-snowball proof render: positive case
status=pass, atelier checks clean; negative case (deliberate stock import
+ missing art_direction) returns status=fail with both findings named.

F7 — skills/meta/reviewer.md gets a "Composition Authoring Mode Review"
section that enforces the inversion at every stage:

  - proposal: composition_mode must be a presented decision with both
    options; hero briefs default to atelier; templated for hero requires
    an explicit sanctioned reason.
  - scene_plan/edit: any stock cut.type in an atelier piece is CRITICAL;
    bespoke.{entry, composition_id, art_direction} required.
  - compose: consumes final_review.checks.atelier from F6; mandates a
    recorded distinctness review (the human taste call the tool can't
    automate — its absence is itself CRITICAL).
  - publish: blocks ship on any unresolved atelier finding.

Engine knowledge stays reusable; creative components don't.
This commit is contained in:
calesthio
2026-06-27 11:01:00 -07:00
parent 578f0f1bb1
commit 5481226faf
2 changed files with 152 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/video/video_compose.py
+122 -10
View File
@@ -789,18 +789,130 @@ class VideoCompose(BaseTool):
error=f"Atelier render completed but output file missing: {output_path}",
)
return ToolResult(
success=True,
data={
"operation": "render",
"composition_mode": "atelier",
"entry": str(entry_path),
"composition_id": comp_id,
"output": str(output_path),
},
artifacts=[str(output_path)],
# --- Atelier post-render review -------------------------------------
# The cut-schema paths run _run_final_review (technical/visual/audio
# probes + transcript-vs-script). Atelier MUST do the same so hero
# renders aren't shipped without the safety net — and additionally
# enforce the bespoke doctrine: no stock-registry imports, an
# art-direction declaration must exist. The distinctness review
# ("could this be any other product's video?") stays human; what we
# automate here is the *doctrine bypass*, not the taste call.
final_review = self._run_final_review(
output_path=output_path,
edit_decisions=edit_decisions,
proposal_packet=inputs.get("proposal_packet"),
narration_transcript_path=inputs.get("narration_transcript_path"),
script_text=inputs.get("script_text"),
)
atelier_checks = self._run_atelier_checks(entry_path, bespoke)
final_review.setdefault("checks", {})["atelier"] = atelier_checks
final_review["issues_found"] = list(final_review.get("issues_found", [])) + atelier_checks.get("issues", [])
# Escalate atelier-critical issues (stock reuse) to the overall status.
# Missing art-direction is a warning, not a fail — it shows in issues_found.
if atelier_checks.get("stock_reuse_detected"):
final_review["status"] = "fail"
final_review["recommended_action"] = "re_author"
data: dict[str, Any] = {
"operation": "render",
"composition_mode": "atelier",
"entry": str(entry_path),
"composition_id": comp_id,
"output": str(output_path),
"final_review": final_review,
"final_review_status": final_review.get("status"),
}
if final_review.get("status") == "fail":
return ToolResult(
success=False,
error=(
"Atelier render produced an invalid output:\n"
+ "\n".join(f" • {i}" for i in final_review.get("issues_found", []))
),
data=data,
artifacts=[str(output_path)],
)
return ToolResult(success=True, data=data, artifacts=[str(output_path)])
# Stock-registry import patterns that violate the atelier doctrine.
# Any of these inside a bespoke project tree means a creative component
# was reused instead of hand-stitched. Engine knowledge (the `remotion`
# package, `@remotion/*`, project-local files) is fine.
_ATELIER_STOCK_IMPORT_RE = (
r"""from\s+["']("""
# parent-traversed paths into the stock src/
r"""(?:\.\./)+src/(?:components|Explainer|CinematicRenderer|"""
r"""TitledVideo|TalkingHead|CollageBurst|LyricOverlay|cinematic|crucix|phantom)"""
# or absolute-ish paths into the same
r"""|remotion-composer/src/(?:components|Explainer|CinematicRenderer|"""
r"""TitledVideo|TalkingHead|CollageBurst|LyricOverlay|cinematic|crucix|phantom)"""
r""")"""
)
def _run_atelier_checks(self, entry_path: Path, bespoke: dict[str, Any]) -> dict[str, Any]:
"""Doctrine-enforcement checks specific to atelier mode.
Returns a dict with two checks:
- stock_reuse_detected (bool) + offending_imports (list) — CRITICAL,
fails the render. Catches `import X from "../../src/components/..."`
and similar reuse of stock creative components.
- art_direction_declared (bool) + art_direction (str|None) — WARNING.
Forces step 1 of the bespoke-composition skill (commit to a fresh
art direction per video) to be written down rather than skipped.
"""
import re as _re
issues: list[str] = []
offending: list[dict[str, str]] = []
project_dir = entry_path.parent
pat = _re.compile(self._ATELIER_STOCK_IMPORT_RE)
try:
for f in project_dir.rglob("*"):
if not f.is_file() or f.suffix.lower() not in {".tsx", ".ts", ".jsx", ".js"}:
continue
try:
txt = f.read_text(encoding="utf-8", errors="replace")
except Exception:
continue
for m in pat.finditer(txt):
offending.append({"file": str(f.relative_to(project_dir)), "import": m.group(1)})
except Exception as e: # pragma: no cover — never let the check itself break a render
issues.append(f"atelier stock-reuse scan errored: {e}")
stock_reuse_detected = bool(offending)
if stock_reuse_detected:
issues.append(
"atelier doctrine violation: bespoke project imports from the stock "
"creative registry. Hand-author the scene instead — the registry is "
"a mechanics codex, not a parts bin. Offending imports: "
+ ", ".join(f"{o['file']} → {o['import']}" for o in offending[:5])
+ ("…" if len(offending) > 5 else "")
)
art_direction = bespoke.get("art_direction") or bespoke.get("art_direction_note")
art_direction_declared = bool(art_direction and str(art_direction).strip())
if not art_direction_declared:
issues.append(
"atelier warning: no bespoke.art_direction declared. Per "
"skills/meta/bespoke-composition.md step 1, every atelier piece must "
"commit to a fresh art direction (palette, type, motion, signature "
"device) before authoring. Pass edit_decisions.bespoke.art_direction "
"as a short note or a path to art-direction.md."
)
return {
"stock_reuse_detected": stock_reuse_detected,
"offending_imports": offending,
"art_direction_declared": art_direction_declared,
"art_direction": str(art_direction) if art_direction else None,
"issues": issues,
}
@staticmethod
def _build_theme_from_playbook(
playbook_name: str | None,